Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-1793] Update non-matching identity screen #6559

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented Dec 17, 2024

Short description

This PR updates the screen shown when the user who is authenticating is not the same that activated the wallet.

List of changes proposed in this pull request

  • Updated ITW_IDENTITY_NOT_MATCHING_SCREEN

How to test

Authenticate with a different identity than the one used to activate the wallet. You should see the following screen:

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1793

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.16%. Comparing base (4f204b4) to head (f486ad9).
Report is 908 commits behind head on master.

Files with missing lines Patch % Lines
...lifecycle/screens/ItwIdentityNotMatchingScreen.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6559      +/-   ##
==========================================
+ Coverage   48.42%   49.16%   +0.73%     
==========================================
  Files        1488     1554      +66     
  Lines       31617    32069     +452     
  Branches     7669     7262     -407     
==========================================
+ Hits        15311    15767     +456     
- Misses      16238    16263      +25     
+ Partials       68       39      -29     
Files with missing lines Coverage Δ
...features/itwallet/navigation/ItwStackNavigator.tsx 36.36% <ø> (ø)
...lifecycle/screens/ItwIdentityNotMatchingScreen.tsx 7.14% <0.00%> (ø)

... and 1737 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc66860...f486ad9. Read the comment docs.

@gispada gispada changed the title chore(IT Wallet): [SIW-1793] update non matching identity screen chore(IT Wallet): [SIW-1793] Update non-matching identity screen Dec 18, 2024
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants